Fix various setuid/setgid permissions fallout #26628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
force-pushed
the
fix/perms-fallout-misc
branch
from
27ec1b8
to
98b2e48
Compare
25 tasks
dtzWill
changed the title
Mic92
force-pushed
the
fix/perms-fallout-misc
branch
from
f691a67
to
ae147e3
Compare
vcunat
approved these changes
Jun 17, 2017
| preConfigure = '' | ||
| sed -e 's/getline/my_getline/' -i score.c | ||
|
|
||
| chmod a+rw config.h | ||
| cat >>config.h <<EOF | ||
| #define HERE "@nixos-packaged" | ||
| #define WWW 0 | ||
| #define OWNER "'$(whoami)'" | ||
| #define OWNER "$(whoami)" |
There was a problem hiding this comment.
Running whoami isn't a good idea at all, is it's an attempt for non-determinism.
There was a problem hiding this comment.
OMG, the build script checks if the user exist. I'll just leave it; it's just a game...
vcunat
added a commit
that referenced
this pull request
Jun 17, 2017
|
Oh, the remarks.... these aren't sticky bits – sticky are odd numbers in the fourth-from-right digit in octal format. |
vcunat
added a commit
that referenced
this pull request
Jul 3, 2017
(cherry picked from commit d88c0cf) There were just a couple of conflicts, apparently someone has already fixed rewritefs and cron on 17.03. I re-checked that all those do build now (with a new-enough nix daemon).
|
I'll leave them even if they're wrong, as there's too much of other stuff to do... |
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
(cherry picked from commit d88c0cf) There were just a couple of conflicts, apparently someone has already fixed rewritefs and cron on 17.03. I re-checked that all those do build now (with a new-enough nix daemon).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes all packages explicitly listed as failing in #26600.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)