Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-osd: init at unstable-2023-11-15 #266323

Merged
merged 1 commit into from Nov 24, 2023
Merged

cosmic-osd: init at unstable-2023-11-15 #266323

merged 1 commit into from Nov 24, 2023

Conversation

nyabinary
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary force-pushed the cosmic-osd branch 2 times, most recently from 502a9f5 to 97f2f4d Compare November 10, 2023 01:44
@nyabinary nyabinary mentioned this pull request Nov 10, 2023
Open
29 tasks
lilyinstarlight
lilyinstarlight reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me and it seems to build, but I needed the following change to get it to run correctly, since they currently hardcode the path of the polkit helper

pkgs/by-name/co/cosmic-osd/package.nix Show resolved Hide resolved
@nyabinary nyabinary force-pushed the cosmic-osd branch 2 times, most recently from 8c4a296 to 5b4572b Compare November 16, 2023 14:09
@nyabinary nyabinary changed the title cosmic-osd: init at unstable-2023-11-07 cosmic-osd: init at unstable-2023-11-15 Nov 24, 2023
lilyinstarlight
lilyinstarlight approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once ofborg is done, assuming builds succeed

Thank you!

@lilyinstarlight lilyinstarlight merged commit c793562 into NixOS:master Nov 24, 2023
23 checks passed
@nyabinary nyabinary deleted the cosmic-osd branch January 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyinstarlight lilyinstarlight lilyinstarlight approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyabinary @lilyinstarlight