Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authelia: fix update script #266455

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

06kellyjac
Copy link
Member

Description of changes

Prepare for future release
Don't use a patch that is prone to needing updating
Visibly fail

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Prepare for future release
Don't use a patch that is prone to needing updating
Visibly fail
@IreneKnapp
Copy link
Contributor

I tested this (manually tweaking NEW_VERSION to "4.38.0-beta3", as we discussed on Matrix), and it works great!

Kudos also on the change to substituteInPlace instead of a patch file, I wouldn't have thought of that.

@06kellyjac
Copy link
Member Author

Ah I didn't see v4.38.0-beta3 but I guess it was a branch rather than pre-release tag?

glad it works now

@IreneKnapp
Copy link
Contributor

correct, it's a branch, hence easy to miss. of course nixpkgs shouldn't actually update authelia until there's a non-beta release, but it's good for the script to work :)

@marsam marsam merged commit 3da53eb into NixOS:master Dec 23, 2023
26 checks passed
@nicomem nicomem mentioned this pull request Apr 15, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants