Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy-sarif: init at 0.4.2 #266558

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Nov 10, 2023

Description of changes

clippy-sarif is a CLI tool to convert clippy diagnostics into SARIF. It is a part of the sarif-rs group of projects.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@uncenter
Copy link
Member

Result of nixpkgs-review pr 266558 run on aarch64-darwin 1

1 package built:
  • clippy-sarif

@getchoo
Copy link
Member Author

getchoo commented May 8, 2024

rebased on master and refactored a bit

@isabelroses
Copy link
Member

isabelroses commented May 8, 2024

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package failed to build:
  • clippy-sarif

the error I got is bad archive: input doesn't look like a Nix archive

@uncenter
Copy link
Member

uncenter commented May 8, 2024

Result of nixpkgs-review pr 266558 run on aarch64-darwin 1

1 package built:
  • clippy-sarif

@getchoo
Copy link
Member Author

getchoo commented May 9, 2024

@isabelroses could you try to run this again? i'm not really sure how this could happen unless there was maybe a corrupted download for the archive. this doesn't happen for me (on the same architecture) or uncenter, so i'm a bit curious here

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package built:
  • clippy-sarif

@isabelroses
Copy link
Member

@isabelroses could you try to run this again? i'm not really sure how this could happen unless there was maybe a corrupted download for the archive. this doesn't happen for me (on the same architecture) or uncenter, so i'm a bit curious here

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package built:

Yeah I figured the same, just ran it on a different system to be 100% sure. it's working now.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1623

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 266558 run on x86_64-linux 1

1 package built:
  • clippy-sarif

@SuperSandro2000 SuperSandro2000 merged commit 943264e into NixOS:master Jun 25, 2024
24 checks passed
@getchoo getchoo deleted the pkgs/clippy-sarif/init branch June 25, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants