Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.sorl-thumbnail: 12.9.0 -> 12.10.0; rename from sorl_thumbnail #266978

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

natsukium
Copy link
Member

Description of changes

Changelog: https://github.com/jazzband/sorl-thumbnail/blob/12.10.0/CHANGES.rst

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

natsukium commented Nov 12, 2023

Result of nixpkgs-review pr 266978 at 823b2d0 run on aarch64-darwin 1

2 packages built successfully:
  • python310Packages.sorl-thumbnail
  • python311Packages.sorl-thumbnail

Result of nixpkgs-review pr 266978 at 823b2d0 run on x86_64-linux 1

2 packages built successfully:
  • python310Packages.sorl-thumbnail
  • python311Packages.sorl-thumbnail

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 15bec51 into NixOS:master Nov 12, 2023
22 checks passed
@natsukium natsukium deleted the sorl-thumbnail branch November 12, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants