apacheAnt_1_9: remove #266987
apacheAnt_1_9: remove #266987
Conversation
| @@ -67,6 +67,7 @@ mapAliases ({ | |||
| alsaUtils = alsa-utils; # Added 2021-06-10 | |||
| angelfish = libsForQt5.kdeGear.angelfish; # Added 2021-10-06 | |||
| ansible_2_12 = throw "Ansible 2.12 goes end of life in 2023/05 and can't be supported throughout the 23.05 release cycle"; # Added 2023-05-16 | |||
| apacheAnt_1_9 = throw "Ant 1.9 has been removed since it's not used in nixpkgs anymore"; # Added 2023-11-12 | |||
There was a problem hiding this comment.
I don't know if it makes sense but couldn't it alias to apacheAnt instead? 🤔
There was a problem hiding this comment.
We can do that but it's weird to alias ant 1.9 to ant 1.10. Did we do that in other cases? If it's the convention I have no problem to follow it.
There was a problem hiding this comment.
Hmm I don't know what convention is on the matter. It is just a thought from a UX perspective to avoid unnecessary throws when users upgrade their systems.
There was a problem hiding this comment.
I thought it's better to throw instead of alias to another version and maybe breaks something else later.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1244 |
Description of changes
It was added due to jdk 7. JDK 7 has been removed so this is not needed anymore.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@matthewbauer