Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klipper-firmware: update simulator config #267070

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

vtuan10
Copy link
Contributor

@vtuan10 vtuan10 commented Nov 12, 2023

Description of changes

Update out-of-date simulator.cfg so that klipper-firmware builds again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member

evils commented Nov 12, 2023

builds again, also with the new release of klipper
no idea if the result is useful as i don't have a machine to test it on

@evils
Copy link
Member

evils commented Nov 15, 2023

ZHF: #265948

@evils evils added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label Nov 15, 2023
@Artturin Artturin merged commit 5e9f00b into NixOS:master Nov 19, 2023
25 checks passed
@vtuan10 vtuan10 deleted the update-klipper-sim-cfg branch November 19, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants