wordlists: refactor #267555
Merged
wordlists: refactor #267555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janik-Haag
reviewed
Nov 15, 2023
h7x4
force-pushed
the
pkgs-refactor-wordlists
branch
from
ef1eaa4
to
420e396
Compare
pbsds
reviewed
Nov 16, 2023
h7x4
force-pushed
the
pkgs-refactor-wordlists
branch
from
f6df2b6
to
da9efaa
Compare
h7x4
changed the title
|
Result of 1 package built:
|
Janik-Haag
reviewed
Nov 17, 2023
h7x4
force-pushed
the
pkgs-refactor-wordlists
branch
3 times, most recently
from
0028eba
to
61c4a30
Compare
h7x4
changed the title
Janik-Haag
approved these changes
Nov 17, 2023
Janik-Haag
reviewed
Nov 17, 2023
- Remove version tag - Filter out non-wordlist content from wordlist packages - Split up the derivation into several logical parts - Reorder package inputs to be in the order which they are used - Add h7x4 as maintainer Co-authored-by: Peder Bergebakken Sundt <pbsds@hotmail.com> Co-authored-by: Janik H. <janik@aq0.de>
h7x4
force-pushed
the
pkgs-refactor-wordlists
branch
from
61c4a30
to
198106a
Compare
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Ref #260240
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)