New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elisp updates #268477
Elisp updates #268477
Conversation
@adisbladis @AndersonTorres separate PR for grammar updates as requested. |
Rebase and remove the elisp updates |
@bhankas You didn't update tree-sitter grammars, did you? You've updated some elisp packages and added some grammars for updating, but didn't update grammars. If that's your intention, it would be nice if you changed the PR title. |
@akirak Yes, I've been meaning to update the PR but haven't been able to. Will try to fix in a day or two. |
Apologies for extreme late response, but I think this one is conservative enough. This builds on top of #295805, and updates elisp packages. The change in Still unsure how to get @AndersonTorres please take a look whenever possible. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3629 |
Remove the Elisp updates. They mass-rebuild and therefore should go to Staging. |
In that case this PR can be closed in favor of #295805 , what do you say? |
Yes, it's even better. About the |
Thanks, closing this. |
Description of changes
Includes and requires changes from #295805. Will keep it rebased on top of it.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)