Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eid-mw: 5.1.11 -> 5.1.13 #269408

Closed
wants to merge 1 commit into from
Closed

eid-mw: 5.1.11 -> 5.1.13 #269408

wants to merge 1 commit into from

Conversation

chvp
Copy link
Member

@chvp chvp commented Nov 23, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@evils
Copy link
Member

evils commented Nov 26, 2023

this seems to break the login test page https://iamapps.belgium.be/tma/?lang=en

firefox still says "eID software not found" and "a recent enough version of the belgian electronic identity card software could not be found"
that notification sends me to a download page which leads to 5.1.11

i've had firefox crash many times trying to test this with the eid config on NixOS
(hasn't crashed since i removed that config)
(firefox 120.0 on sway 1.8.1 on nixos-unstable from today with linux 6.6.2)
managed to click the wrong thing when firefox started into safe mode so i had to
settings -> privacy & security -> Security -> Certificates -> security devices... -> load -> browse -> find eid-mw in nix store (build in nixpkgs and readlink) and select lib/pkcs11/beidpkcs11.so -> OK again
after that it would prompt for the ID request and PIN again

with 5.1.13 it either times out or fails outright but i've not gotten it to work
with 5.1.11 it still fails half the time -_-

damn i hate dealing with CSAM (not least because they called it that and don't explain the name)

@chvp
Copy link
Member Author

chvp commented Nov 26, 2023

Hmm, I tested it with my setup and it worked. I'll check it again tomorrow.

@chvp
Copy link
Member Author

chvp commented Nov 27, 2023

I tested it again this morning, it does work on my machine (also firefox 120.0, eid add-on 1.0.32, riverwm 0.2.4 and nixos-unstable 24.05.20231124.5a09cb4).

@chvp
Copy link
Member Author

chvp commented Nov 27, 2023

Also, to find lib/pkcs11/beidpkcs11.so, /run/current-system/sw/lib/pkcs11 is the easier path to access it.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3250

@chvp
Copy link
Member Author

chvp commented Jan 17, 2024

I've used this multiple times without issues.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1391

@chvp chvp closed this Jan 25, 2024
@chvp chvp deleted the upd/eid-mw branch January 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants