zammad: 5.1.4 -> 6.1.0 #269469
Merged
zammad: 5.1.4 -> 6.1.0 #269469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build zammad |
NetaliDev
force-pushed
the
zammad-update
branch
from
33fe116
to
e8ef968
Compare
Janik-Haag
reviewed
Dec 3, 2023
There was a problem hiding this comment.
Diff looks good, we should post in the breaking-changes-announcement-for-unstable/ and wait two or so days before merging since this release has breaking changes.
But the test still fails for me, now with this error: error: boost::bad_format_string: format-string is ill-formed did you experience the same?
|
Hmm strange, the test works for me now and apparently for ofborg too. But while we figure this out, I will post the announcement in the breaking changes thread. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/41 |
n0emis
approved these changes
Dec 3, 2023
garbas
reviewed
Dec 4, 2023
NetaliDev
force-pushed
the
zammad-update
branch
from
e1938e1
to
531fa59
Compare
Janik-Haag
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR updates
zammadto 6.1.0 and updates the module to work with the new version. It also adds me as a maintainer for the package and module.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 馃憤 reaction to pull requests you find important.