Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 54.0 -> 54.0.1, firefox-esr: 52.2.0esr -> 52.2.1esr #26988

Merged
merged 3 commits into from
Jun 30, 2017
Merged

firefox, firefox-bin: 54.0 -> 54.0.1, firefox-esr: 52.2.0esr -> 52.2.1esr #26988

merged 3 commits into from
Jun 30, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 30, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij to be a potential reviewer.

@NeQuissimus NeQuissimus merged commit 7f9ec26 into NixOS:master Jun 30, 2017
NeQuissimus added a commit that referenced this pull request Jun 30, 2017
@NeQuissimus
Merge pull request #26988 from taku0/firefox-bin-54.0.1
8a8bc4f 
firefox, firefox-bin: 54.0 -> 54.0.1,  firefox-esr: 52.2.0esr -> 52.2.1esr

(cherry picked from commit 7f9ec26)
@NeQuissimus
Copy link
Member

In 17.03 with 7f9ec26

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#26988 from taku0/firefox-bin-54.0.1
e81ea9d 
firefox, firefox-bin: 54.0 -> 54.0.1,  firefox-esr: 52.2.0esr -> 52.2.1esr

(cherry picked from commit 7f9ec26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @mention-bot @NeQuissimus