Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.shopify.ruby-lsp: init at 0.5.8 #269910

Conversation

robbevp
Copy link
Contributor

@robbevp robbevp commented Nov 25, 2023

Description of changes

Add new vscode extensions for ruby LSP

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 馃憤 reaction to pull requests you find important.

@robbevp robbevp force-pushed the vscode-extensions.shopify.ruby-lsp-0.4.20 branch from b2a03b5 to cac14e8 Compare January 29, 2024 09:14
@robbevp robbevp changed the title vscode-extensions.shopify.ruby-lsp: Init at 0.4.20 vscode-extensions.shopify.ruby-lsp: Init at 0.5.8 Jan 29, 2024
@robbevp
Copy link
Contributor Author

robbevp commented Jan 29, 2024

Updated so init starts at most recent release

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3354

@SuperSandro2000 SuperSandro2000 changed the title vscode-extensions.shopify.ruby-lsp: Init at 0.5.8 vscode-extensions.shopify.ruby-lsp: init at 0.5.8 Feb 5, 2024
@SuperSandro2000 SuperSandro2000 merged commit 6455d84 into NixOS:master Feb 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants