Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-ld: mark as broken on 32 bit targets #269919

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

mfrischknecht
Copy link
Contributor

@mfrischknecht mfrischknecht commented Nov 25, 2023

nix-ld's source code doesn't build on 32 bit targets due to a missing #define value since the tool switched from musl to nolibc in 2021.

See Mic92/nix-ld#64

Hydra job: https://hydra.nixos.org/build/241835411#tabs-summary
Log: https://hydra.nixos.org/build/241835411/nixlog/2

Relevant log excerpt:

[3/8] Compiling C object nix-ld.p/src_nix-ld.c.o
FAILED: nix-ld.p/src_nix-ld.c.o 
gcc -Inix-ld.p -I. -I.. -I../vendor/nolibc -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -fcf-protection --param=ssp-buffer-size=4 -fPIE -fno-asynchronous-unwind-tables -fno-ident -ffreestanding -static-pie -DPTR_SIZE=4 -MD -MQ nix-ld.p/src_nix-ld.c.o -MF nix-ld.p/src_nix-ld.c.o.d -o nix-ld.p/src_nix-ld.c.o -c ../src/nix-ld.c
../src/nix-ld.c: In function 'total_mapping_size':
../src/nix-ld.c:127:32: error: expected expression before ';' token
  127 |   size_t addr_min = UINTPTR_MAX;
      |                                ^
[4/8] Generating symbol file test/libexample-lib.so.p/libexample-lib.so.symbols
ninja: build stopped: subcommand failed.

Description of changes

Marks nix-ld as broken for 32 bit targets.

#ZurichZHF

ZHF: #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mfrischknecht mfrischknecht changed the title ZHF: Mark nix-ld as broken on 32 bit targets Mark nix-ld as broken on 32 bit targets Nov 25, 2023
@infinisil
Copy link
Member

infinisil commented Nov 27, 2023

Please change the commit subject to nix-ld: ..., this way CI triggers automatically for the package.

I'll also call it manually for now though (Edit: I guess there's no point to it, the derivation didn't change, no rebuild necessary :))

@ofborg build nix-ld

@infinisil infinisil added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-23.11 labels Nov 27, 2023
@infinisil infinisil requested a review from Mic92 November 27, 2023 13:31
@Mic92 Mic92 changed the title Mark nix-ld as broken on 32 bit targets nix-ld: mark as broken on 32 bit targets Nov 27, 2023
@Mic92 Mic92 merged commit 34d92e9 into NixOS:master Nov 27, 2023
27 of 28 checks passed
@Mic92
Copy link
Member

Mic92 commented Nov 27, 2023

Fixed title on squash.

Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants