x11idle: init at unstable-2017-07-01 #27062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving from org-mode's current origin/master
0xABAB
reviewed
Jul 2, 2017
pkgs/tools/misc/x11idle/default.nix
Outdated
| unpackPhase = ":"; | ||
| buildInputs = [ xlibs.libXScrnSaver xlibs.libX11 ]; | ||
| meta = { | ||
| description = "Gather the current idle time from X11."; |
There was a problem hiding this comment.
I had to read this description two times to figure out what it meant.
Please replace with Compute consecutive idle time duration for current X session of current user with millisecond resolution. In the long description mention that Idle time passes when e.g. the user doesn't move the mouse or uses the keyboard.
Mic92
reviewed
Jul 3, 2017
pkgs/tools/misc/x11idle/default.nix
Outdated
| Idle time passes when the user does not act, i.e. when the user doesn't move the mouse or use the keyboard. | ||
| ''; | ||
| homepage = "http://orgmode.org/"; | ||
| license = stdenv.lib.licenses.free; |
Mic92
reviewed
Jul 3, 2017
pkgs/tools/misc/x11idle/default.nix
Outdated
| @@ -0,0 +1,19 @@ | |||
| { stdenv, xlibs, fetchgit }: | |||
|
|
|||
| stdenv.mkDerivation { name = "x11idle"; | |||
There was a problem hiding this comment.
Version number is missing in name attribute.
|
A reference in all-packages.nix is missing. |
|
I squashed my changes with your commits. Note that for commit titles, we have also convention how we name them (ex: x11idle: init at unstable-2017-07-01). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Define the x11idle package from Emacs Org Mode to make use easier.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)