p7zip: Update CVE-2016-9296 patch URL. #27075
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debian source for this patch file has gone away, rendering this derivation unbuildable from scratch. This change updates the URL to a src.fedoraproject.org location that is still serving a p7zip patch. This file is not the same bytewise, so I'm also updating the hash; I didn't manage to find a location still serving a file with the original hash, and my best guess is that this one is functionally equivalent.
vcunat
approved these changes
Jul 3, 2017
vcunat
added a commit
that referenced
this pull request
Jul 3, 2017
(cherry picked from commit 1f0de2d)
vcunat
added a commit
that referenced
this pull request
Jul 3, 2017
We still do mirror the patch (I think), as `nix-build -Q -A p7zip.patches` downloaded it on my machine. I verified that only the diff headers differ; it's still better to have another working download and Fedora's URLs are less likely to disappear than Debian's. /cc #27075.
vcunat
added a commit
that referenced
this pull request
Jul 3, 2017
|
Heh, github is incorrectly showing the merging person again. (I merged and pushed it to master.) EDIT: it's a nitpick but reported to support anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debian source for this patch file has gone away, rendering this derivation
unbuildable from scratch.
This change updates the URL to a src.fedoraproject.org location that is still
serving a p7zip patch. This file is not the same bytewise, so I'm also updating
the hash; I didn't manage to find a location still serving a file with the
original hash, and my best guess is that this one is functionally equivalent.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)