Mariadb: Fix URL for source tarball. #27076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariadb.org appears to have changed their URL schemes, and the tarball URL used by this derivation no longer works, which makes this unbuildable from scratch. This change updates that URL to a mariadb.org location that will still serve this tarball. Hash is unchanged.
vcunat
reviewed
Jul 3, 2017
| @@ -18,8 +18,9 @@ common = rec { # attributes common to both builds | |||
| version = "10.1.21"; | |||
|
|
|||
| src = fetchurl { | |||
| url = "https://downloads.mariadb.org/interstitial/mariadb-${version}/source/mariadb-${version}.tar.gz"; | |||
| url = "https://downloads.mariadb.org/f/mariadb-${version}/source/mariadb-${version}.tar.gz/from/http%3A//ftp.hosteurope.de/mirror/archive.mariadb.org/?serve"; | |||
There was a problem hiding this comment.
The new URL looks like requesting a specific mirror, which isn't a nice way...
There was a problem hiding this comment.
Hmm, apparently half of their mirrors don't have our version anymore :-/
vcunat
added a commit
that referenced
this pull request
Jul 3, 2017
Not even all their mirrors serve our version, unfortunately. (cherry picked from commit cc83f35)
vcunat
approved these changes
Jul 3, 2017
vcunat
added a commit
that referenced
this pull request
Jul 3, 2017
Not even all their mirrors serve our version, unfortunately.
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Not even all their mirrors serve our version, unfortunately. (cherry picked from commit cc83f35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mariadb.org appears to have changed their URL schemes, and the tarball URL used
by this derivation no longer works, which makes this unbuildable from scratch.
This change updates that URL to a mariadb.org location that will still serve
this tarball.
Hash is unchanged.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)