argocd-vault-plugin: fix version output #270985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
fix/argocd-vault-plugin/version
branch
from
97bc9d1
to
f582ed9
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3146 |
|
Result of 1 package built:
|
rjpcasalino
reviewed
Dec 26, 2023
| @@ -13,9 +18,23 @@ buildGoModule rec { | |||
|
|
|||
| vendorHash = "sha256-0PrGrcS8Gx0cVImGrlmXlycFgWCTLjg2ISi0OhYoPpw="; | |||
|
|
|||
| ldflags = [ | |||
| "-X=github.com/argoproj-labs/argocd-vault-plugin/version.Version=v${version}" | |||
| "-X=github.com/argoproj-labs/argocd-vault-plugin/version.BuildDate=1970-01-01T00:00:00Z" | |||
There was a problem hiding this comment.
why 1970-01-01T00:00:00Z as BuildDate?
There was a problem hiding this comment.
would builtins.currentTime make sense here at all? Just curious.
There was a problem hiding this comment.
1970-01-01T00:00:00Z is the Unix epoch, it is the "zero" of Unix time basically.
builtins.currentTime is impure, using it would result in non-reproducible builds
rjpcasalino
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 馃憤 reaction to pull requests you find important.