Eval fixes from release-attrpaths-superset.nix optimization (part 2) #271123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Nov 30, 2023
Mic92
force-pushed
the
pr/release-outpaths-
branch
from
e2f5849
to
310cda5
Compare
ghost
approved these changes
Nov 30, 2023
| in if missingArgs == {} then makeOverridable f allArgs else abort error; | ||
| in if missingArgs == {} | ||
| then makeOverridable f allArgs | ||
| else throw "lib.customisation.callPackageWith: ${error}"; |
There was a problem hiding this comment.
What was the motivation for this specific change? It makes it so nix-env -qa no longer fails and just silently drops the attrpath when querying pacakges that have missing arguments (and therefore ofborg and other CI relies on the previous behavior to catch missing argument errors during outpath calculation)
This still smells like a bug in nix-env regardless to me, so this bit in Nixpkgs probably doesn't need to be changed back, but I'm still trying to trace down in that code where/why this throw would be ignored rather than propagated as an eval error
There was a problem hiding this comment.
Nope, this is intended behavior in Nix:
Throw an error message s. This usually aborts Nix expression
evaluation, but innix-env -qaand other commands that try to
evaluate a set of derivations to get information about those
derivations, a derivation that throws an error is silently skipped
(which is not the case forabort).
https://nixos.org/manual/nix/stable/language/builtins.html#builtins-throw
There was a problem hiding this comment.
Oh damn yeah. Probably the entire reason this is in nix-env at all is because we historically haven't had anything like this PR, which would've prevented packages from not being evaluatable.
There was a problem hiding this comment.
Revert and eval fixes in #278777
This was referenced Jan 4, 2024
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 5, 2024
This reverts f8ea911, see also NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
Was broken in 9fddd79 but not caught due to NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
This was not caught when the package was introduced because of NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
Was broken by feb114f And not caught due to NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
Was broken since 7dd3469 but not caught due to NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
Was broken since introduced, but not caught due to NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
This reverts f8ea911, see also NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
… false Was broken since initialised in 9b2d4d2 but not noticed due to NixOS#271123 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 7, 2024
… false Was broken since initialised in 9b2d4d2 but not noticed due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken by feb114f And not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken since 7dd3469 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken since introduced, but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
This reverts f8ea911, see also NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken in 9fddd79 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
This was not caught when the package was introduced because of NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken by feb114f And not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken since 7dd3469 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
Was broken since introduced, but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 8, 2024
This reverts f8ea911, see also NixOS#271123 (comment)
infinisil
added a commit
that referenced
this pull request
Jan 8, 2024
This very weirdly broke the channel evaluation: https://hydra.nixos.org/build/245871962/nixlog/1 It appears that this attribute is only evaluated by Hydra, _not_ by ofborg. So this wouldn't have been detected by CI anyways in the PR that introduced the problem: #276800. However, due to #271123 (comment), the channel only broke once that was fixed with #278777 Whether the fix is good, I don't know, but the failing-on-darwin attribute doesn't exist anymore with this commit, making the tarball build succeed again: nix-build pkgs/top-level/release.nix -A tarball
github-actions bot
pushed a commit
to arcnmx/nixpkgs-lib
that referenced
this pull request
Jan 9, 2024
This reverts 5629aec, see also NixOS/nixpkgs#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 9, 2024
Was broken in 9fddd79 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 9, 2024
This was not caught when the package was introduced because of NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 9, 2024
Was broken by feb114f And not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 9, 2024
Was broken since 7dd3469 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 9, 2024
Was broken since introduced, but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 9, 2024
This reverts f8ea911, see also NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 10, 2024
Was broken in 9fddd79 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 10, 2024
This was not caught when the package was introduced because of NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 10, 2024
Was broken by feb114f And not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 10, 2024
Was broken since 7dd3469 but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 10, 2024
Was broken since introduced, but not caught due to NixOS#271123 (comment)
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 10, 2024
This reverts f8ea911, see also NixOS#271123 (comment)
bryango
pushed a commit
to bryango/nixpkgs
that referenced
this pull request
Jan 10, 2024
Was broken since introduced, but not caught due to NixOS#271123 (comment) (cherry picked from commit 6946071)
slam-bert
pushed a commit
to slam-bert/nixpkgs
that referenced
this pull request
Jan 11, 2024
This very weirdly broke the channel evaluation: https://hydra.nixos.org/build/245871962/nixlog/1 It appears that this attribute is only evaluated by Hydra, _not_ by ofborg. So this wouldn't have been detected by CI anyways in the PR that introduced the problem: NixOS#276800. However, due to NixOS#271123 (comment), the channel only broke once that was fixed with NixOS#278777 Whether the fix is good, I don't know, but the failing-on-darwin attribute doesn't exist anymore with this commit, making the tarball build succeed again: nix-build pkgs/top-level/release.nix -A tarball
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
Jan 14, 2024
This reverts 4c75ef3, see also NixOS/nixpkgs#271123 (comment)
github-actions bot
pushed a commit
to Mic92/nixpkgs
that referenced
this pull request
Jan 14, 2024
This very weirdly broke the channel evaluation: https://hydra.nixos.org/build/245871962/nixlog/1 It appears that this attribute is only evaluated by Hydra, _not_ by ofborg. So this wouldn't have been detected by CI anyways in the PR that introduced the problem: NixOS#276800. However, due to NixOS#271123 (comment), the channel only broke once that was fixed with NixOS#278777 Whether the fix is good, I don't know, but the failing-on-darwin attribute doesn't exist anymore with this commit, making the tarball build succeed again: nix-build pkgs/top-level/release.nix -A tarball
flandweber
pushed a commit
to flandweber/nixpkgs
that referenced
this pull request
Jan 21, 2024
This very weirdly broke the channel evaluation: https://hydra.nixos.org/build/245871962/nixlog/1 It appears that this attribute is only evaluated by Hydra, _not_ by ofborg. So this wouldn't have been detected by CI anyways in the PR that introduced the problem: NixOS#276800. However, due to NixOS#271123 (comment), the channel only broke once that was fixed with NixOS#278777 Whether the fix is good, I don't know, but the failing-on-darwin attribute doesn't exist anymore with this commit, making the tarball build succeed again: nix-build pkgs/top-level/release.nix -A tarball
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
context #269356
Purpose is to reduce the size of the PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.