ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5 #271342

PhDyellow · 2023-12-01T02:17:30Z

Description of changes

ryzen_monitor_ng is a tool for monitoring power information on desktop AMD processors.
It can also set parameters for the CPU, so can offer some of the features of Ryzen Master on Linux.

It depends on the linux kernel driver ryzen_smu.

ryzen_smu includes a userspace program monitor_cpu.

https://gitlab.com/mann1x/ryzen_smu

https://github.com/mann1x/ryzen_monitor_ng

Things done

Priorities

Add a 👍 reaction to pull requests you find important.

PhDyellow · 2023-12-01T02:19:57Z

Tested on a 5900X CPU in a clevo laptop.

Cryolitia

I would like to introduce these two patches to support Phonix and Rembrandt.

Cryolitia@9aecdf4#diff-2cc356432ce45563cde8df0d10e36f41c3524284e9ceb526c281f3a61219ffdaR44

Would you like to co-maintain the module ryzen-smu, together. I take the liberty of making this request. I would be honored if you would accept it.

pkgs/os-specific/linux/ryzen-smu/monitor-cpu.nix

Cryolitia · 2023-12-19T02:55:58Z

pkgs/os-specific/linux/ryzen-smu/default.nix

+  version = "0.1.5";
+
+  src = fetchFromGitLab {
+    owner = "mann1x";


Please tell us why you choose a fork instead of the origin repo.

The ryzen_smu programs have gone through a lot of forks themselves.

ryzen_smu is the original ryzen_smu. It included monitor_cpu. ryzen_monitor extended monitor_cpu and ryzen_monitor_ng extended ryzen_monitor.

To support ryzen_monitor_ng, mann1x forked ryzen_smu but hasn't merged the changes. See here and here.

However, when I built ryzen_monitor_ng from mann1x's repo it wouldn't run because of a version mismatch in libsmu. kvic-z's fork of ryzen_monitor_ng corrects the version mismatch and adds Matisse.

The patches you suggest come from yet another fork.

I do like your approach of patching the original repos. I hope it doesn't lead to conflicts between mann1x's fork and moson-mo's. Worth a try, even if it leads to a lot of patches.

It's so complex that I have just realized. I have noticed that the origin repo hasn't updated since half year ago. Do you think if it's a good idea that we maintain a fork in person, picking PRs and testing, then releasing.

Anyway, please at least leave a comment in the Nix packaging source code about it as long as you choose a repo which is not the origin one. Otherwise, other people who don't see this discussion would get confused.

It is looking like we will need to maintain a repo with all the patches. PRs are not getting merged upstream quickly. Are you willing to set up the repo? I will change the src if you do.

To support ryzen_monitor_ng, mann1x forked ryzen_smu but hasn't merged the changes. See here and here.

I have noticed the same commits with different sha256 in mann1x's repo and leogx9r's repo, such as https://gitlab.com/leogx9r/ryzen_smu/-/commit/e61177d0ddaebfaeca52094b20a2289287a0838b and https://gitlab.com/mann1x/ryzen_smu/-/commit/adaf53c77dc68b99643ab7af729eb9c592cf5e01. Has it already rebased or I miss something other place.

It is looking like we will need to maintain a repo with all the patches. PRs are not getting merged upstream quickly. Are you willing to set up the repo? I will change the src if you do.

https://github.com/Cryolitia/ryzen_smu

nixos/modules/hardware/ryzen-smu.nix

nixos-discourse · 2023-12-19T03:23:26Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/ryzenadj-and-ryzen-smu/31326/4

PhDyellow · 2023-12-20T12:17:42Z

I would be happy to co-maintain it with you. Given the number of forks and patches that ryzen_smu uses, I'll need the help.

Your patches contain some better nix code than I have written, but it looks like you wrote it independently to this PR. May I pull in the relevant parts of your patches and merge/squash/rebase the whole PR?

Cryolitia · 2023-12-21T10:14:33Z

I would be happy to co-maintain it with you. Given the number of forks and patches that ryzen_smu uses, I'll need the help.

Your patches contain some better nix code than I have written, but it looks like you wrote it independently to this PR. May I pull in the relevant parts of your patches and merge/squash/rebase the whole PR?

Feel free to use my source code ^_^

Cryolitia · 2023-12-21T18:48:50Z

Tested on multi AMD processors, results here: https://gitlab.com/leogx9r/ryzen_smu/-/merge_requests/12#note_1704774029

TLDR: Each processor has different issues, and no one processor has all the features working properly.

PhDyellow · 2023-12-27T08:46:36Z

Thanks @Cryolitia, I have updated this PR with your recommendations. The patches apply cleanly to the mann1x/ryzen_smu fork, so I think we can get away without starting yet another repo.

If it looks good to you, I will squash the commits down for a clean merge.

PhDyellow · 2023-12-27T08:47:56Z

Please test ryzen_smu with ryzen_monitor_ng, it produces more accurate readings than monitor_cpu

Cryolitia · 2023-12-27T13:20:34Z

It's so complex that I have just realized. I have noticed that the origin repo hasn't updated since half year ago. Do you think if it's a good idea that we maintain a fork in person, picking PRs and testing, then releasing.

Just because that I have found other interesting PRs , such as https://gitlab.com/leogx9r/ryzen_smu/-/merge_requests/13

It's unacceptable to add more and more patches for a dead repo. And It will be a disaster one day these patches conflict.

nixos/modules/hardware/cpu/amd-ryzen-smu.nix

pkgs/os-specific/linux/ryzen-monitor-ng/default.nix

pkgs/os-specific/linux/ryzen-smu/default.nix

Cryolitia · 2023-12-27T14:56:54Z

please change this PR's title to ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5

pkgs/os-specific/linux/ryzen-monitor-ng/default.nix

Cryolitia · 2023-12-27T15:00:24Z

tested PhDyellow@9221b58

PhDyellow · 2023-12-28T01:19:41Z

Thanks for testing. It looks like the patches aren't working yet.

Can you share the output of:

sudo cat /sys/kernel/ryzen_smu_drv/codename

PhDyellow · 2023-12-28T01:22:11Z

Ah, got it! monitor_cpu wasn't patched, so it wouldn't accept Phoenix CPUs.

nixos/doc/manual/release-notes/rl-2405.section.md

nixos/modules/hardware/cpu/amd-ryzen-smu.nix

nixos/modules/programs/ryzen-monitor-ng.nix

SuperSandro2000 · 2024-03-25T09:45:25Z

pkgs/by-name/ry/ryzen_monitor_ng/package.nix

+    make clean
+    rm src/ryzen_monitor
+    make


Can't we use makeTarget and preBuild?

Thanks for the pointer, code should be clearer now.

pkgs/os-specific/linux/ryzen-smu/default.nix

Aleksanaa

Lgtm. Please squash your commits.

Aleksanaa · 2024-04-10T07:48:03Z

Why this suggested change was reverted? #271342 (comment)

Aleksanaa · 2024-04-10T12:25:06Z

Sorry, the nixos module should be added in another commit (not package), and follow commit conventions in https://github.com/NixOS/nixpkgs/tree/master/nixos#commit-conventions

PhDyellow · 2024-04-10T13:27:55Z

Why this suggested change was reverted? #271342 (comment)

Thanks for catching that, I didn't mean to revert that.

Sorry, the nixos module should be added in another commit (not package), and follow commit conventions in https://github.com/NixOS/nixpkgs/tree/master/nixos#commit-conventions

Makes sense, I will split up the commits as soon as I can.

A Linux kernel driver that exposes access to the SMU (System Management Unit) for certain AMD Ryzen Processors. Contains monitor_cpu, a userspace tool for viewing info. Using fork of original to match ryzen_monitor_ng, a more advanced userspace tool for accessing the SMU via this kernel module, planned for a later commit.

Provide a module for installing ryzen_smu, a Linux kernel driver that exposes access to the SMU (System Management Unit) for certain AMD Ryzen Processors. Installs monitor_cpu, a userspace tool for viewing info. Using fork of original to match ryzen_monitor_ng, a more advanced userspace tool for accessing the SMU via this kernel module, planned for a later commit.

A userspace tool for setting and getting AMD CPU power and performance parameters. Relies on the ryzen_smu kernel module.

A userspace tool for setting and getting AMD CPU power and performance parameters. The module adds `ryzen_monitor_ng` to `environment.systemPackages` and enables the `ryzen-smu` module, as `ryzen_monitor_ng` requires the `ryzen_smu` kernel module to function.

nixos-discourse · 2024-05-10T05:10:17Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/looking-for-documentation-on-maketargets-within-stdenv-mkderivation/45182/1

github-actions bot added 6.topic: nixos 8.has: documentation 8.has: changelog 8.has: module (update) labels Dec 1, 2023

h7x4 added the 8.has: module (new) label Dec 1, 2023

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Dec 1, 2023

Cryolitia reviewed Dec 19, 2023

View reviewed changes

PhDyellow requested review from piegamesde and Janik-Haag as code owners December 27, 2023 06:52

ofborg bot requested a review from Cryolitia December 27, 2023 08:50

Cryolitia reviewed Dec 27, 2023

View reviewed changes

nixos/modules/hardware/cpu/amd-ryzen-smu.nix Outdated Show resolved Hide resolved

Cryolitia reviewed Dec 27, 2023

View reviewed changes

pkgs/os-specific/linux/ryzen-monitor-ng/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/ryzen-smu/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/ryzen-smu/default.nix Outdated Show resolved Hide resolved

Cryolitia reviewed Dec 27, 2023

View reviewed changes

pkgs/os-specific/linux/ryzen-monitor-ng/default.nix Outdated Show resolved Hide resolved

PhDyellow changed the title ~~ryzen_smu and ryzen_monitor_ng~~ ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5 Dec 28, 2023

ofborg bot requested a review from Cryolitia December 28, 2023 01:22

SuperSandro2000 reviewed Mar 25, 2024

View reviewed changes

ofborg bot requested a review from Cryolitia April 10, 2024 02:09

Cryolitia approved these changes Apr 10, 2024

View reviewed changes

Cryolitia requested a review from Aleksanaa April 10, 2024 03:02

Aleksanaa approved these changes Apr 10, 2024

View reviewed changes

PhDyellow force-pushed the ryzen_smu branch from 4dce753 to 373a553 Compare April 10, 2024 07:11

ofborg bot requested a review from Cryolitia April 10, 2024 07:35

Cryolitia approved these changes Apr 10, 2024

View reviewed changes

PhDyellow force-pushed the ryzen_smu branch from 373a553 to 3337500 Compare April 10, 2024 12:15

Aleksanaa approved these changes Apr 10, 2024

View reviewed changes

Cryolitia requested review from SuperSandro2000, Cryolitia and wegank April 10, 2024 12:24

Cryolitia approved these changes Apr 10, 2024

View reviewed changes

Cryolitia added 12.approvals: 3+ and removed 12.approvals: 2 labels Apr 10, 2024

ofborg bot requested a review from Cryolitia April 10, 2024 12:40

Cryolitia approved these changes Apr 10, 2024

View reviewed changes

Phil Dyer added 5 commits April 11, 2024 11:39

ryzen-monitor-ng: init at 2.0.5

a352dc5

A userspace tool for setting and getting AMD CPU power and performance parameters. Relies on the ryzen_smu kernel module.

doc: add information about ryzen-monitor-ng and ryzen-smu modules

97899b5

PhDyellow force-pushed the ryzen_smu branch from 3337500 to 97899b5 Compare April 11, 2024 01:51

ofborg bot requested a review from Cryolitia April 11, 2024 02:15

Aleksanaa merged commit 029c95c into NixOS:master Apr 11, 2024
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5 #271342

ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5 #271342

PhDyellow commented Dec 1, 2023 •

edited

PhDyellow commented Dec 1, 2023

Cryolitia left a comment

Cryolitia Dec 19, 2023

PhDyellow Dec 20, 2023

Cryolitia Dec 21, 2023

PhDyellow Dec 28, 2023

Cryolitia Jan 3, 2024

Cryolitia Jan 3, 2024

nixos-discourse commented Dec 19, 2023

PhDyellow commented Dec 20, 2023

Cryolitia commented Dec 21, 2023

Cryolitia commented Dec 21, 2023

PhDyellow commented Dec 27, 2023

PhDyellow commented Dec 27, 2023

Cryolitia commented Dec 27, 2023 •

edited

Cryolitia commented Dec 27, 2023

Cryolitia commented Dec 27, 2023 •

edited

PhDyellow commented Dec 28, 2023

PhDyellow commented Dec 28, 2023

SuperSandro2000 Mar 25, 2024

PhDyellow Apr 10, 2024

Aleksanaa left a comment

Aleksanaa commented Apr 10, 2024

Aleksanaa commented Apr 10, 2024

PhDyellow commented Apr 10, 2024

nixos-discourse commented May 10, 2024

ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5 #271342

ryzen_smu: init at 0.1.5, ryzen_monitor_ng: init at 2.0.5 #271342

Conversation

PhDyellow commented Dec 1, 2023 • edited

Description of changes

Things done

Priorities

PhDyellow commented Dec 1, 2023

Cryolitia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nixos-discourse commented Dec 19, 2023

PhDyellow commented Dec 20, 2023

Cryolitia commented Dec 21, 2023

Cryolitia commented Dec 21, 2023

PhDyellow commented Dec 27, 2023

PhDyellow commented Dec 27, 2023

Cryolitia commented Dec 27, 2023 • edited

Cryolitia commented Dec 27, 2023

Cryolitia commented Dec 27, 2023 • edited

PhDyellow commented Dec 28, 2023

PhDyellow commented Dec 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aleksanaa left a comment

Choose a reason for hiding this comment

Aleksanaa commented Apr 10, 2024

Aleksanaa commented Apr 10, 2024

PhDyellow commented Apr 10, 2024

nixos-discourse commented May 10, 2024

PhDyellow commented Dec 1, 2023 •

edited

Cryolitia commented Dec 27, 2023 •

edited

Cryolitia commented Dec 27, 2023 •

edited