Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hareThirdParty.hare-toml: init at 0.1.0 #271761

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

onemoresuza
Copy link
Contributor

@onemoresuza onemoresuza commented Dec 2, 2023

Description of changes

Initialize hare-toml, an implementation of the TOML format for Hare, at 0.1.0.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 馃憤 reaction to pull requests you find important.

@onemoresuza
Copy link
Contributor Author

onemoresuza commented Dec 2, 2023

Before this PR is ready for review, #271476 must be merged.

#271476 was merged.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3109

@onemoresuza onemoresuza force-pushed the hare-toml branch 6 times, most recently from a67b572 to d2d89fa Compare December 21, 2023 20:57
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1337

Copy link
Contributor

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 271761 run on x86_64-linux 1

1 package built:
  • hareThirdParty.hare-toml

Patches are merged into master, and the build logs, derivation and build results LGTM. Thanks!

@pbsds pbsds merged commit 9257497 into NixOS:master Dec 30, 2023
24 checks passed
@onemoresuza onemoresuza deleted the hare-toml branch December 30, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants