-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
badlion-client: 3.15.0 -> 4.1.2 #272828
base: master
Are you sure you want to change the base?
badlion-client: 3.15.0 -> 4.1.2 #272828
Conversation
Result of 1 package built:
|
Result of 1 package failed to build:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
┃ error: hash mismatch in fixed-output derivation '/nix/store/rihxh7cgx2pd1a30gnix6b60zrvi98z8-BadlionClient.drv':
┃ specified: sha256-HqMgY9+Xnp4uSTWr//REZGv3p7ivwLX97vxGD5wqu9E=
┃ got: sha256-qI/5eNgaDgyLC9NOrHaDkITZsYsBLTOyqzGwobUDKh8=
Seems you need to update the hash
ecd8374
to
33dd9ec
Compare
Result of 1 package built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1301 |
|
||
src = fetchurl { | ||
url = "https://client-updates-cdn77.badlion.net/BadlionClient"; | ||
hash = "sha256-HqMgY9+Xnp4uSTWr//REZGv3p7ivwLX97vxGD5wqu9E="; | ||
hash = "sha256-qI/5eNgaDgyLC9NOrHaDkITZsYsBLTOyqzGwobUDKh8="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the hash changed again,
is there a stable URL that we can use ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to find it but now unfortunately it not, You know a way to fix this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we contact upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can but i think it not gonna help because launcher is design to automatic update
What if we have a place where we cache badlion app image for specific version? Is that gonna work? Or anyone have better idea? |
Not sure it would be easy to do in a trustworthy way, depends on where you were thinking of storing it. |
I used the contact us form to suggest adding a version number to the download link and got this as response: |
Description of changes
badlion-client: 3.15.0 -> 4.0.0
badlion-client: add me as package maintainers
changelog: https://www.badlion.net/forum/thread/352866
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.