Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badlion-client: 3.15.0 -> 4.1.2 #272828

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

starzation
Copy link
Contributor

@starzation starzation commented Dec 8, 2023

Description of changes

badlion-client: 3.15.0 -> 4.0.0
badlion-client: add me as package maintainers

changelog: https://www.badlion.net/forum/thread/352866

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@starzation
Copy link
Contributor Author

Result of nixpkgs-review pr 272828 run on x86_64-linux 1

1 package built:
  • badlion-client

@cafkafk
Copy link
Member

cafkafk commented Dec 9, 2023

Result of nixpkgs-review pr 272828 run on x86_64-linux 1

1 package failed to build:
  • badlion-client

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

┃ error: hash mismatch in fixed-output derivation '/nix/store/rihxh7cgx2pd1a30gnix6b60zrvi98z8-BadlionClient.drv':
┃          specified: sha256-HqMgY9+Xnp4uSTWr//REZGv3p7ivwLX97vxGD5wqu9E=
┃             got:    sha256-qI/5eNgaDgyLC9NOrHaDkITZsYsBLTOyqzGwobUDKh8=

Seems you need to update the hash

@cafkafk
Copy link
Member

cafkafk commented Dec 12, 2023

Result of nixpkgs-review pr 272828 run on x86_64-linux 1

1 package built:
  • badlion-client

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1301


src = fetchurl {
url = "https://client-updates-cdn77.badlion.net/BadlionClient";
hash = "sha256-HqMgY9+Xnp4uSTWr//REZGv3p7ivwLX97vxGD5wqu9E=";
hash = "sha256-qI/5eNgaDgyLC9NOrHaDkITZsYsBLTOyqzGwobUDKh8=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hash changed again,
is there a stable URL that we can use ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to find it but now unfortunately it not, You know a way to fix this issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we contact upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can but i think it not gonna help because launcher is design to automatic update

@starzation starzation changed the title badlion-client: 3.15.0 -> 4.0.0 badlion-client: 3.15.0 -> 4.1.0 Feb 4, 2024
@starzation starzation marked this pull request as draft February 4, 2024 14:24
@starzation starzation mentioned this pull request Mar 8, 2024
13 tasks
@starzation
Copy link
Contributor Author

starzation commented Mar 8, 2024

What if we have a place where we cache badlion app image for specific version? Is that gonna work? Or anyone have better idea?

CC: @kirillrdy @cafkafk @qubitnano @jbgi

@cafkafk
Copy link
Member

cafkafk commented Mar 8, 2024

What if we have a place where we cache badlion app image for specific version? Is that gonna work? Or anyone have better idea?

CC: @kirillrdy @cafkafk @qubitnano @jbgi

Not sure it would be easy to do in a trustworthy way, depends on where you were thinking of storing it.

@wegank wegank changed the title badlion-client: 3.15.0 -> 4.1.0 badlion-client: 3.15.0 -> 4.1.2 Mar 18, 2024
@wegank wegank marked this pull request as ready for review March 18, 2024 14:47
@wegank wegank mentioned this pull request Mar 19, 2024
13 tasks
@sdht0
Copy link
Contributor

sdht0 commented Mar 20, 2024

I used the contact us form to suggest adding a version number to the download link and got this as response: I will make sure to forward this suggestion to our team so they can see if it is worth implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants