Introduce 10.13 darwin-stubs #273006
Draft
Introduce 10.13 darwin-stubs #273006
+85
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `applePackageMapping` function will allow us to keep expressions for the newer releases separate from the originals where necessary, without needing to change `generate-sdk-packages.sh`. If we ever want to support multiple versions of source releases simultaneously we should consider changing that to point to versioned subdirectories of all the packages. Many of the source releases introduced here will need changes to the expression to build successfully. These will be introduced one by one.
Releases with dependencies on other releases, e.g., libresolv depends on Libinfo, mDNSResponder and configdHeaders, were getting those releases from pkgs.darwin rather than pkgs.darwin."10.13.6". By making the scope of callPackage overridable we can manipulate which packages are used to supply dependencies.
Get the stubs from GitHub so Hydra will be able to build these changes.
TODO: PR to NixOS/darwin-stubs and point the source there as an
authoritative location.
ofborg
bot
added
6.topic: darwin
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
Get the stubs from GitHub so Hydra will be able to build these changes.
Note this isn't intended to be merged as is.
TODO: PR to NixOS/darwin-stubs and point the source there as an authoritative location.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.