polari: unbreak #27320
Merged
polari: unbreak #27320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtojnar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @groxxda, @vcunat and @lethalman to be potential reviewers. |
|
The message is caused by #16327 and it should not affect functionality. I
need to figure out how to debug the app.
…On 12 July 2017 at 12:26, Jörg Thalheim ***@***.***> wrote:
Do I need gnome to run this application?
$ polari
** (org.gnome.Polari:9543): WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
$
it exits with just this message from my awesome wm session.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27320 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AArCY98YOovtRDDBjuQwrCWZn1EnHCvNks5sNJ9XgaJpZM4OVHXL>
.
|
|
The Travis build failed due to no space left on device from a rebuild of gapps. As for the connection problem, journal contains the following: It looks like both the problems are caused by a dbus services not recognized, even though they are installed. |
|
After reloading dbus using |
|
Okay, I tested it with #26113 and it works fine. |
FRidh
added
the
6.topic: GNOME
|
Gnome pn Nix doesn't seem to be that actively maintained anymore. These changes look fine to me. |
jtojnar
force-pushed
the
fix/unbreak-polari
branch
2 times, most recently
from
9226eb5
to
9f4edfb
Compare
Some programs store the executable in a different place and link it from the `bin` directory. For example, Polari links `$out/bin/polari` to `$out/share/polari/org.gnome.Polari`. `wrapGAppsHook` did not follow symlinks so it was not able to wrap Polari, making it unable to access GObject introspection definitions required for running the program. I made the wrapping script follow symlinks to fix this corner case.
The build was failing due to missing telepathy_logger dependency, I added it. Additionally, the connection to server was failing due to telepathy executables not having an access to dconf, which was fixed in NixOS#26113. Lastly, when I tried running Polari directly, it terminated with SIGTRAP and the following error: (org.gnome.Polari:22998): GLib-GIO-ERROR **: Settings schema 'org.gnome.desktop.interface' is not installed adding `gnome3.gsettings_desktop_schemas` as a buildInput fixed that.
jtojnar
force-pushed
the
fix/unbreak-polari
branch
from
9f4edfb
to
ec6f832
Compare
|
@FRidh This is now good to go. |
|
Thanks. I've pushed it to staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
The build was failing due to missing telepathy_logger dependency. I added it.
Since bin/polari file is actually a symbolic link,
wrapGAppsHookdid not wrap it, making it unable to access GObject introspection definitions required for running the program. I made the wrapping script follow symlinks to fix this corner case.GNOME expects the executable to have the same base name as the associated desktop file. When I wrapped the executable, I broke this correspondence. That is why I renamed the executable. For convenience, I also created a symlink with the original name.Edit: This was probably just an issuel with dbus needing to be restarted to find the service file for launching from GNOME Shell.What is missing
The app is now running but it cannot connect to server due to in-memory gsettings (#26131).
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)