libsForQt515.audiotube: depend on kpurpose#273263
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Feb 5, 2024
Merged
libsForQt515.audiotube: depend on kpurpose#273263SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
Audiotube depends on Purpose, and fails to launch if it is unavailable. Fixes that by adding `kpurpose` as a build dependency. Closes NixOS#228179.
github-actions
bot
added
the
6.topic: qt/kde
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3357 |
Member
|
@ofborg build libsForQt5.audiotube plasma5Packages.audiotube |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
AudioTube depends on the Purpose library, and fails to launch if Purpose is not in the environment. This PR fixes that by adding
kpurposeas a build dependency.Closes #228179.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.