Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/logseq-webapp: init; logseq-webapp: init at 0.10.3 #273532

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

onny
Copy link
Contributor

@onny onny commented Dec 11, 2023

Description of changes

Packaging LogSeq, semantic knowledge wiki, as a web service.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@trzpiot
Copy link
Contributor

trzpiot commented Dec 11, 2023

What is the difference / improvement compared to logseq or using the Docker image?

@onny
Copy link
Contributor Author

onny commented Dec 11, 2023

What is the difference / improvement compared to logseq or using the Docker image?

As far as I can tell the logseq package is the electron desktop app. I want to package the web version build from source. Also a service could be added: services.logseq-web.enable = true;

@onny onny force-pushed the logseq-webapp branch 3 times, most recently from 4e96a58 to db21e84 Compare December 30, 2023 02:02
@onny onny marked this pull request as ready for review December 30, 2023 02:02

config = lib.mkIf cfg.enable {

services.caddy = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do many other services use caddy as their web server? All of the other ones I've seen in nixpkgs have standardized on nginx.

Copy link
Contributor

@trzpiot trzpiot Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few services that use Caddy (e.g. WordPress and DokuWiki), but usually configurable as an alternative via the options.

Copy link
Member

@phaer phaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that it can be very hard to build and package apps like Logseq from source, but on the other hand I am not sure how much value there is in just downloading pre-built assets, copying them into the nix store and putting a vhost in front of it.

You mention the service as a benefit, but all options only affect the vhost, there's nothing to configure for logseq here atm.

@onny
Copy link
Contributor Author

onny commented Dec 30, 2023

Yes I tried to compile from source but unfortunately it is very difficult. I'll have a look if there might be something to configure in the web app and update this PR

@@ -30,6 +30,8 @@ In addition to numerous new and upgraded packages, this release has the followin

- [ollama](https://ollama.ai), server for running large language models locally.

- [logseq-webapp](ihttps://logseq.com), a privacy-first, open-source platform for knowledge management and collaboration. Available as [services.logseq-webapp](#opt-services.logseq-webapp.enable).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo in the url...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants