-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/logseq-webapp: init; logseq-webapp: init at 0.10.3 #273532
base: master
Are you sure you want to change the base?
Conversation
What is the difference / improvement compared to logseq or using the Docker image? |
As far as I can tell the logseq package is the electron desktop app. I want to package the web version build from source. Also a service could be added: services.logseq-web.enable = true; |
4e96a58
to
db21e84
Compare
|
||
config = lib.mkIf cfg.enable { | ||
|
||
services.caddy = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do many other services use caddy as their web server? All of the other ones I've seen in nixpkgs have standardized on nginx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that it can be very hard to build and package apps like Logseq from source, but on the other hand I am not sure how much value there is in just downloading pre-built assets, copying them into the nix store and putting a vhost in front of it.
You mention the service as a benefit, but all options only affect the vhost, there's nothing to configure for logseq here atm.
Yes I tried to compile from source but unfortunately it is very difficult. I'll have a look if there might be something to configure in the web app and update this PR |
@@ -30,6 +30,8 @@ In addition to numerous new and upgraded packages, this release has the followin | |||
|
|||
- [ollama](https://ollama.ai), server for running large language models locally. | |||
|
|||
- [logseq-webapp](ihttps://logseq.com), a privacy-first, open-source platform for knowledge management and collaboration. Available as [services.logseq-webapp](#opt-services.logseq-webapp.enable). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo in the url...
Description of changes
Packaging LogSeq, semantic knowledge wiki, as a web service.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.