minetest: 5.7.0 -> 5.8.0, cleanup #273557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use finalAttrs * Touch support is now unconditional
|
@GrahamcOfBorg build minetestclient minetestserver minetest-touch |
DeeUnderscore
suggested changes
Dec 11, 2023
pkgs/games/minetest/default.nix
Outdated
Comment on lines
72
to
73
| (lib.cmakeFeature "CMAKE_INSTALL_DOCDIR" "share/doc") | ||
| (lib.cmakeFeature "CMAKE_INSTALL_DOCDIR" "share/doc") |
There was a problem hiding this comment.
This outputs docs to share/doc/ directly, so we get eg share/doc/README.md. We'll want to set the value to share/doc/minetest or share/doc/${finalAttrs.pname}.
|
Result of 6 packages built:
|
* Inline the generic builder, since we don't build multiple versions anymore * Remove unused patches, flags, and overrides * Remove minetest_game, it has been debundled * Use finalAttrs * Use lib.cmake* * Add a top-level attribute for the touch variant * Define the server- and client-only variants through overrides in all-packages.nix * Move the *_5 aliases to top-level/aliases.nix * General cleanup Closes NixOS#273207
DeeUnderscore
approved these changes
Dec 12, 2023
|
Thanks for the cleanup! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://blog.minetest.net/2023/12/04/5.8.0-released/
irrlichtmt: 1.9.0mt10 -> 1.9.0mt13
minetest: 5.7.0 -> 5.8.0, cleanup
anymore
all-packages.nix
Closes #273207
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.