Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-init: 23.3.3 -> 23.4.1, fix race condition on AWS #273707

Merged
merged 5 commits into from
Jan 20, 2024

Conversation

illustris
Copy link
Contributor

@illustris illustris commented Dec 12, 2023

Description of changes

The automatic updates from #273497 and #277870 fail tests because of this upstream change: canonical/cloud-init@0044c83
The nixos support patch for cloud-init had to be updated accordingly.
nixosTests.cloud-init has also been updated to make it fail faster.
A race condition with DHCPCD reported in #268986 has also been fixed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@quantenzitrone
Copy link
Contributor

Result of nixpkgs-review pr 273707 run on x86_64-linux 1

2 packages built:
  • cloud-init
  • cloud-init.dist

@illustris illustris changed the title cloud-init: 23.3.3 -> 23.4.1 cloud-init: 23.3.3 -> 23.4.1, fix race condition on AWS Jan 3, 2024
@quantenzitrone
Copy link
Contributor

Result of nixpkgs-review pr 273707 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
2 packages built:
  • cloud-init
  • cloud-init.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3267

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1392

@amaxine amaxine merged commit f0dd758 into NixOS:master Jan 20, 2024
26 checks passed
sergeykranga pushed a commit to extole/nixpkgs that referenced this pull request Feb 7, 2024
cloud-init: 23.3.3 -> 23.4.1, fix race condition on AWS
sergeykranga pushed a commit to extole/nixpkgs that referenced this pull request Feb 7, 2024
cloud-init: 23.3.3 -> 23.4.1, fix race condition on AWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants