Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossplane-cli: 1.14.3 -> 1.14.5 #274712

Merged
merged 1 commit into from
Dec 24, 2023
Merged

crossplane-cli: 1.14.3 -> 1.14.5 #274712

merged 1 commit into from
Dec 24, 2023

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Dec 16, 2023 •
edited
Loading

crossplane-cli: 1.14.3 -> 1.14.5

Release: https://github.com/crossplane/crossplane/releases/tag/v1.14.5

Changelog: crossplane/crossplane@v1.14.3...v1.14.5

  • Add version test

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from selfuryon December 16, 2023 12:55
selfuryon
selfuryon approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1334

@superherointj superherointj changed the title crossplane-cli: 1.14.3 -> 1.14.4 crossplane-cli: 1.14.3 -> 1.14.5 Dec 23, 2023
@ofborg ofborg bot requested a review from selfuryon December 23, 2023 13:07
selfuryon
selfuryon approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsam marsam merged commit 8bfffb4 into NixOS:master Dec 24, 2023
25 checks passed
@superherointj superherointj deleted the crossplane-cli-1.14.4 branch December 25, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfuryon selfuryon selfuryon approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@superherointj @nixos-discourse @selfuryon @marsam @delroth