Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5: 5.9.0 -> 5.9.1 #27485

Merged
merged 1 commit into from
Aug 4, 2017
Merged

qt5: 5.9.0 -> 5.9.1 #27485

merged 1 commit into from
Aug 4, 2017

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jul 19, 2017

Motivation for this change

Qt bugfix release
There are some security fixes in QtWebengine

This release has full source compatibility with 5.9.0, all old Nix specific patches still apply.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from ttuegel July 19, 2017 06:28
@adisbladis adisbladis mentioned this pull request Jul 19, 2017
8 tasks
@adisbladis
Copy link
Member Author

Is there any reason why this is not merged? Maybe it should go to staging first?

@globin
Copy link
Member

globin commented Aug 4, 2017

This should wait for the eval after ad83979 which should fix the remaining binutils issues, needed for a unstable channel bump

@ttuegel
Copy link
Member

ttuegel commented Aug 4, 2017

This was not merged because it fell off my TODO list. Sorry about that! Since we are waiting on master, I will merge this into staging, because that's what it's for.

@ttuegel ttuegel merged commit ac55c66 into NixOS:staging Aug 4, 2017
ttuegel added a commit that referenced this pull request Aug 4, 2017
@adisbladis
Copy link
Member Author

It happens, no worries. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants