Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaPackages.nvim-client: remove #274865

Merged
merged 1 commit into from Dec 17, 2023
Merged

luaPackages.nvim-client: remove #274865

merged 1 commit into from Dec 17, 2023

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Dec 17, 2023

Description of changes

nvim-client (lua-client) is now part of neovim core.

The nix package is broken, and breaks the Neovim build when doCheck = true.

cc @teto

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member

NickCao commented Dec 17, 2023

5 packages removed:
lua5.1-nvim-client (†0.2.4-1) lua5.2-nvim-client (†0.2.4-1) lua5.3-nvim-client (†0.2.4-1) lua5.4-nvim-client (†0.2.4-1) luajit2.1-nvim-client (†0.2.4-1)

Nothing to be built.

@teto teto merged commit 6e3af65 into NixOS:master Dec 17, 2023
17 checks passed
teto pushed a commit to neovim/neovim that referenced this pull request Dec 22, 2023
updates nixpkgs version to reflect the removal of nvim-client in the build see NixOS/nixpkgs#274865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants