docker service: add option to do automatic pruning #27503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to run the prune job periodically on a machine. By default the if enabled the job is run once a week. The structure is similar to how system.autoUpgrade works.
|
@bachp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tailhook, @Mic92 and @offlinehacker to be potential reviewers. |
fpletz
approved these changes
Jul 19, 2017
NeQuissimus
reviewed
Jul 20, 2017
| default = false; | ||
| description = '' | ||
| Whether to periodically prune Docker resources. If enabled, a systemd timer will run | ||
| <literal>docker system prune -f</literal> once a day. |
There was a problem hiding this comment.
It runs according to the schedule below, not once a day, right?!
There was a problem hiding this comment.
Yes that would be more correct.
fpletz
added a commit
that referenced
this pull request
Jul 21, 2017
|
Thanks
Am 21.07.2017 4:55 nachm. schrieb "Franz Pletz" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In nixos/modules/virtualisation/docker.nix
<#27503 (comment)>:
> @@ -94,6 +94,37 @@ in
<command>docker</command> daemon.
'';
};
+
+ autoPrune = {
+ enable = mkOption {
+ type = types.bool;
+ default = false;
+ description = ''
+ Whether to periodically prune Docker resources. If enabled, a systemd timer will run
+ <literal>docker system prune -f</literal> once a day.
Fixed in 1697684
<1697684>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27503 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAUX76jMvp_AOqv1YBmAFxKfvlCptp5aks5sQLvHgaJpZM4OdFqM>
.
|
bugworm
pushed a commit
to bugworm/nixpkgs
that referenced
this pull request
Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This allows to run the prune job periodically on a machine.
By default the if enabled the job is run once a week.
The structure is similar to how system.autoUpgrade works.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)