nixos/k3s: extend k3s module

[rorosen]

Description of changes

Extend the k3s module to enable the usage of Helm charts and container images in air-gapped environments. Additionally, the manifests option allows to specify arbitrary manifests that are deployed by k3s automatically. It is now possible to deploy Kubernetes workloads using the k3s module.

The following k3s features are enabled by this contribution:

• Auto-Deploying Manifests (AddOns)
• Manually Deploy Images Method
• Using the Helm Controller

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[rorosen]

ping @euank @superherointj @asonix @yajo @nikstur

[superherointj]

@rorosen Your contribution here is valid. Eventually I might get to reviewing this. (I plan testing it.) But I cannot promise when.
In advance, I suggest you to clean-up commits.

(I'm working torward this PR. I just want to solve some building blocks first.)

[rorosen]

Done

[yajo]

IMHO this is a great addition. However, the feature needs nixos tests. Would you be able to add some?

[rorosen]

I added a test for the new features. Let me know if I can do anything else.

[yajo]

It looks great. Just some non-blocking suggestions in case you want to improve it further.

[yajo]

Awesome 🎉

[rorosen]

@superherointj I'm not sure how this works, do I need to do anything else to merge this?

[superherointj]

@superherointj I'm not sure how this works, do I need to do anything else to merge this?

yajo has reviewed, so in theory, any commiter can commit this.

I was meaning to review this PR, but as time is limited I wasn't able to. Sorry.
So, I'll remove myself from this assignment, and let anyone else proceed.

[rorosen]

@yajo can you merge this or is there anything missing?

[superherointj]

@yajo can you merge this or is there anything missing?

To clarify. From the gray check in his approval, it's possible to infer yajo is not a commiter yet, for a commiter it would be green. So, he cannot merge this. In practice, reviewers do triage work for commiters. Commiters look for reviewed PRs to commit.

I'm currently a commiter. And I could indeed merge your PR. But I have not reviewed it myself. And I can't do it right now.
I'm doing other things. I just did some upkeep for K3s and Etcd, for example. That is time sensitive. A release is happening soon. And other things. And I don't commit what I haven't analyzed. But any other commiter can over take this. Mic92 for example, is a commiter too. And also a K3s maintainer. But I suppose, as he is not answering your calls, he might be busy too.
The delay is a consequence of our limited resources (as always in everything).

In case you are wondering, there's a thread on becoming a commiter here: https://github.com/NixOS/nixpkgs/issues/50105
It's basically necessary to have a significant amount of contributions, understand the release process, be decent at Nix. It's not hard. Many people apply but it is never enough people in the sense that the needs are endless.

The roles of reviewers, maintainers and committers are open to anyone to apply for. If no one is answering your call, it's just a matter of people not being available. Which can be frustrating. I know. I'm sorry for that.

I cannot promise you that I will review/merge your PR soon. Because I do have other priority things that I need to do first. As I said before. Anyway, eventually someone will merge, or you'll get more feedback. I suggest you don't worry about it.

Also, you can use your PR in your host either by cherry-picking it or through an overlay or just swapping the nixos module. So you can benefit from your improvement while people here at nixpkgs are still busy. (I do that myself. In fact, everyone here does that.)

If you feel the pace is slow, consider joining in the upkeep of K3s or anything you are interested in, it might speed things a bit on the topics you are interested. In the sense that it is less work for others, so they become more available. But it's hard to predict what happens, right?

Best regards.

[rorosen]

Ok, understood. Thanks for the clarification and sorry for reaching out all the time. I wasn't aware of what was missing. No pressure from my side.