treewide: remove isNull where it decreases readability and code understanding #275548
Conversation
github-actions
bot
added
6.topic: nixos
8.has: module (update)
6.topic: vim
6.topic: erlang
6.topic: lib
There was a problem hiding this comment.
👎 on this. There's general agreement that it shouldn't be deprecated in NixOS/nix#8264
Edit: Now opened NixOS/nix#9645 to undeprecate it
There's no good reason to deprecate it: - For consistency reasons it should continue to exist, such that all primitive types have a corresponding `builtins.is*` primop. - There's no implementation cost to continuing to have this function - It costs users time to try to migrate away from it, e.g. NixOS/nixpkgs#219747 and NixOS/nixpkgs#275548 - Using it can give easier-to-read code like `all isNull list`
SuperSandro2000
force-pushed
the
isnull
branch
from
4ad046d
to
c9764f2
Compare
|
I've changed the PR to only remove it where it decreases readability. Especially |
SuperSandro2000
changed the title
SuperSandro2000
force-pushed
the
isnull
branch
from
c9764f2
to
bcd87fe
Compare
|
Out of all the bad code written in Nixpkgs, this is very far down the list imo. I don't think it's worth doing this. Especially because people will just continue using it regardless. And while this could be automated, it's absolutely not worth the trouble. So really, let's just not worry about this. |
There's no good reason to deprecate it: - For consistency reasons it should continue to exist, such that all primitive types have a corresponding `builtins.is*` primop. - There's no implementation cost to continuing to have this function - It costs users time to try to migrate away from it, e.g. NixOS/nixpkgs#219747 and NixOS/nixpkgs#275548 - Using it can give easier-to-read code like `all isNull list` Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
|
So we no longer want to fix bad code because people could write new bad code? |
| @@ -61,7 +61,7 @@ let | |||
| runHook preConfigure | |||
|
|
|||
| ${./mix-configure-hook.sh} | |||
| ${lib.optionalString (!isNull appConfigPath) | |||
There was a problem hiding this comment.
Especially expression like this one shouldn't go through review as they complicate the code a lot.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.