Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapelib: 1.5.0 -> 1.6.0 #276094

Merged
merged 1 commit into from Dec 23, 2023
Merged

shapelib: 1.5.0 -> 1.6.0 #276094

merged 1 commit into from Dec 23, 2023

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Dec 22, 2023

Description of changes

Update shapelib to the latest version.

List of changes: https://github.com/OSGeo/shapelib/releases/tag/v1.6.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@imincik
Copy link
Contributor Author

imincik commented Dec 22, 2023

Result of nixpkgs-review pr 276094 run on x86_64-linux 1

10 packages built:
  • gnudatalanguage
  • gpsbabel
  • gpsbabel-gui
  • gpsbabel-gui.doc
  • pytrainer
  • pytrainer.dist
  • shapelib
  • tilemaker
  • viking
  • xastir

@imincik
Copy link
Contributor Author

imincik commented Dec 23, 2023

@ehmry , thank you for review.

@imincik imincik merged commit 250be87 into master Dec 23, 2023
27 checks passed
@sikmir
Copy link
Member

sikmir commented Dec 23, 2023

Result of nixpkgs-review pr 276094 run on x86_64-darwin 1

5 packages failed to build:
  • gnudatalanguage
  • gpsbabel
  • gpsbabel-gui
  • gpsbabel-gui.doc
  • viking
1 package built:
  • tilemaker

@r-burns r-burns deleted the shapelib-1.6.0 branch December 23, 2023 20:23
@imincik
Copy link
Contributor Author

imincik commented Dec 24, 2023

Result of nixpkgs-review pr 276094 run on x86_64-darwin 1

5 packages failed to build:

  • gnudatalanguage
  • gpsbabel
  • gpsbabel-gui
  • gpsbabel-gui.doc
  • viking

1 package built:

  • tilemaker

That's not good. @sikmir , what are the failures ? I see shapelib building successfully on Darwin.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants