colstr: init at 1.0.0 #276491
colstr: init at 1.0.0 #276491
Conversation
|
Result of 1 package built:
|
| }; | ||
|
|
||
| nativeBuildInputs = [ gcc ]; | ||
| buildPhase = '' |
There was a problem hiding this comment.
I think there should be a way to get rid of the g++ step here. Then you can change buildPhase to installPhase when copying the binary.
There was a problem hiding this comment.
split up the phases now…
How would you remove the compilation command? There is no makefile.
There was a problem hiding this comment.
Hmm I suppose it's fine as-is. perseus was the only other package I could find that has a g++ buildPhase
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1358 |
|
Please rebase |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1564 |
|
yup, did that. |
Co-authored-by: Donovan Glover <donovan@dglover.co> Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
There was a problem hiding this comment.
Result of nixpkgs-review pr 276491 run on x86_64-linux 1
1 package built:
- colstr
Description of changes
Added colstr package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.