-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.locustio: use flask 0.10.1 instead of 0.12 which broke tests. #27712
Conversation
@AmineChikhaoui, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
Nixpkgs is a curated set where we try to maintain only a single version of each package in order to prevent collisions between multiple versions in a closure. If |
If the purpose was to fix |
@FRidh the changed pkg is locustio. there is no changes to neither flask_assets/octoprint |
@AmineChikhaoui sorry, I misread the diff. Even so, its the same. We won't include an extra version of a package. What does upstream say regarding compatibility with 0.12? |
@FRidh so I think you're right it's probably better to fix it upstream as I tried |
@AmineChikhaoui it must have been broken already on the release of 17.03 then, since we have flask 0.12 since then. |
opened locustio/locust#637 |
Thanks! |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)