maintainers: add @jcelerier #277145
Closed
maintainers: add @jcelerier #277145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not remove the checklist from the PR. Also, the commit message does not follow the commit conventions. |
Janik-Haag
requested review from
minijackson
and removed request for
Janik-Haag and
piegamesde
|
Do you need help with something? |
|
I'd like to access the template without having to redo the PR ^^' |
After discussion on nixpkgs-audio matrix channel (@minijackson)
|
sorry, this fell a bit far in the backlog... |
13 tasks
|
what's the process to get this merged ? :) |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1716 |
Normally this list is added in the same PR where the maintainer is also used, to not collect unused maintainers. |
|
I've pushed this commit into #315409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After discussion on nixpkgs-audio matrix channel (@minijackson)
Adding myself to the maintainers list to co-maintain ossia-score
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.