-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers: add @jcelerier #277145
maintainers: add @jcelerier #277145
Conversation
Please do not remove the checklist from the PR. Also, the commit message does not follow the commit conventions. |
Do you need help with something? |
I'd like to access the template without having to redo the PR ^^' |
After discussion on nixpkgs-audio matrix channel (@minijackson)
sorry, this fell a bit far in the backlog... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
what's the process to get this merged ? :) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1716 |
Normally this list is added in the same PR where the maintainer is also used, to not collect unused maintainers. |
I've pushed this commit into #315409 |
Description of changes
After discussion on nixpkgs-audio matrix channel (@minijackson)
Adding myself to the maintainers list to co-maintain ossia-score
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.