haskell.packages.ghc865Binary: drop unevaluatable packages #278074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`haskell.packages.ghc865Binary` has a few packages that fails to evaluate
by referring non-existent attributes. This turns evaluation attempts into
unrecoverable errors.
Before the change an attempt to instantiate all `ghc810` packages failed
as:
$ nix-instantiate --strict --eval --expr 'with import ./. {}; lib.mapAttrs (n: v: builtins.tryEval (lib.isDerivation v)) haskell.packages.ghc865Binary'
error:
… while evaluating the attribute 'llvmPackages'
at lib/attrsets.nix:1180:11:
1179| attrs:
1180| attrs // { recurseForDerivations = false; };
| ^
1181|
error: value is null while a set was expected
The change follows definition of `pkgs/top-level/haskell-packages.nix`
and also sets `llvmPackages` to `null`. While at it dropped other
references to deleted packages like `exceptions` pin.
trofi
requested review from
cdepillabout,
sternenseemann,
maralorn and
ncfavier
as code owners
|
Thx |
| @@ -91,7 +95,7 @@ self: super: { | |||
| ghc-lib-parser-ex = addBuildDepend self.ghc-lib-parser super.ghc-lib-parser-ex; | |||
|
|
|||
| # This became a core library in ghc 8.10., so we don’t have an "exception" attribute anymore. | |||
| exceptions = super.exceptions_0_10_4; | |||
| exceptions = null; | |||
There was a problem hiding this comment.
We could still build a version of exceptions, but I suppose it hardly matters here.
There was a problem hiding this comment.
Good point! Let's restore it for consistency. Used 0.10.7 in proposed #278310
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Jan 2, 2024
… version In NixOS#278074 I removed `exception` completely. But `nixpkgs` has a version of `exceptions we could use. Let's enable that instead.
13 tasks
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Jan 3, 2024
… version In NixOS#278074 I removed `exception` completely. But `nixpkgs` has a version of `exceptions we could use. Let's enable that instead. Co-authored-by: Dennis Gosnell <cdep.illabout@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskell.packages.ghc865Binaryhas a few packages that fails to evaluate by referring non-existent attributes. This turns evaluation attempts into unrecoverable errors.Before the change an attempt to instantiate all
ghc810packages failed as:The change follows definition of
pkgs/top-level/haskell-packages.nixand also setsllvmPackagestonull. While at it dropped other references to deleted packages likeexceptionspin.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.