Builds abcde with patches for single track CDs and genre 255 issues #278150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds the glanois fork of abcde upstream 2.9.4 dev (currently unreleased) with PR2 and PR4 (so version is called 2.9.4pr4). These fix "eyeD3 rejects genre 255", and "abcde 2.9.3 does not work on single track CDs". Closes nixpkgs NixOS#249422.
|
For testing, I used the single track CD called "A Passion Play", by Jethro Tull. Chrysalis F2 21040, DIDX 2936. The old version fails, this version succeeds. |
|
@gebner, upstream doesn't have these changes, but I sent a message to the mailing list asking about releasing these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds the glanois fork of abcde upstream 2.9.4 dev (currently unreleased) with PR2 and PR4 (so version is called 2.9.4pr4). These fix "eyeD3 rejects genre 255", and "abcde 2.9.3 does not work on single track CDs". Closes nixpkgs #249422.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.