nixos/etcd: fixes etcd failing to start at boot and add openFirewall option #279268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superherointj
changed the title
bryanasdev000
suggested changes
Jan 13, 2024
superherointj
force-pushed
the
etcd-fix-firewall-startup
branch
from
6d979aa
to
7cf589b
Compare
|
ping maintainers of etcd: @offline @endocrimes |
superherointj
force-pushed
the
etcd-fix-firewall-startup
branch
from
7cf589b
to
004ccd5
Compare
superherointj
force-pushed
the
etcd-fix-firewall-startup
branch
2 times, most recently
from
55b8210
to
3238f8c
Compare
superherointj
changed the title
superherointj
force-pushed
the
etcd-fix-firewall-startup
branch
from
3238f8c
to
472e877
Compare
superherointj
changed the title
endocrimes
approved these changes
Jan 18, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1398 |
…option Fixes etcd failing to start at boot for network and firewall not being ready and etcd peers being unavailable because of network/firewall * configure etcd systemd unit to: - delay etcd start-up until network and firewall are ready - restart on failure and be always on * add openFirewall option The official etcd ports are 2379 for client requests and 2380 for peer communication: https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt https://etcd.io/docs/v3.4/op-guide/configuration/
superherointj
force-pushed
the
etcd-fix-firewall-startup
branch
from
7767d06
to
cbe8e0c
Compare
bryanasdev000
approved these changes
Jan 27, 2024
|
@vcunat Would you review this? It's etcd module. |
|
No, I'm afraid I've barely heard etcd mentioned, never used it. |
|
@wegank Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes etcd failing to start at boot for network and firewall not being ready and etcd peers being unavailable because of network/firewall
configure etcd systemd unit to:
add openFirewall option
nixos/etcd: fix etcd category from misc to databases