python310Packages.matplotlib: multiple cleanup commits #279317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
doronbehar
force-pushed
the
pkg/matplotlib
branch
from
d31334c
to
2173e1c
Compare
|
Changed the target to staging. |
|
Hmm CI is not green... I'm fairly sure that if CI was green on master, this commit shouldn't cause a real eval issue on |
|
@GrahamcOfBorg eval |
|
Still, same errors. |
The link to the build docs is outdated, and it doesn't have an updated direct alternative. While I tried to enable at least some of the tests, I encountered NixOS#255262 which is now linked in a comment.
veprbl
force-pushed
the
pkg/matplotlib
branch
from
2173e1c
to
eba8931
Compare
|
Result of 2 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.