Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.sysv-ipc: rename from sysv_ipc #279355

Merged
merged 1 commit into from
Jan 7, 2024
Merged

python311Packages.sysv-ipc: rename from sysv_ipc #279355

merged 1 commit into from
Jan 7, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jan 7, 2024 •
edited

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Jan 7, 2024
Closed
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 279355 run on x86_64-linux 1

4 packages built:
  • python310Packages.sysv-ipc
  • python310Packages.sysv-ipc.dist
  • python311Packages.sysv-ipc
  • python311Packages.sysv-ipc.dist

@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 7, 2024 12:44
@ofborg ofborg bot requested a review from risicle January 7, 2024 13:14
risicle
risicle approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

nixpkgs-review happy, macos 12 x86_64, nixos x86_64

@Stunkymonkey Stunkymonkey merged commit 150baee into NixOS:master Jan 7, 2024
29 of 30 checks passed
@Stunkymonkey Stunkymonkey deleted the sysv-ipc-normalize branch January 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stunkymonkey @risicle @delroth