python311Packages.recursive-pth-loader: rename from recursivePthLoader #279384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stunkymonkey
force-pushed
the
recursive-pth-loader-normalize
branch
from
6703300
to
e6ed329
Compare
|
Result of 1 package blacklisted:
2 packages built:
|
jfly
approved these changes
Jan 14, 2024
| @@ -98,8 +98,4 @@ in { | |||
| python = toPythonModule python; | |||
| # Dont take pythonPackages from "global" pkgs scope to avoid mixing python versions | |||
| pythonPackages = self; | |||
|
|
|||
| # Remove? | |||
| recursivePthLoader = toPythonModule (callPackage ../../../development/python-modules/recursive-pth-loader { }); | |||
There was a problem hiding this comment.
For the record, I don't understand the consequences of moving this.
There was a problem hiding this comment.
I don't understand why it was there in the first place...
There was a problem hiding this comment.
Ok, well, seems reasonable to try to move it and see what happens. Either it's safe and good, or we learn something =)
|
Is |
AndersonTorres
approved these changes
Jan 25, 2024
|
rebasing due to #277321 |
Stunkymonkey
force-pushed
the
recursive-pth-loader-normalize
branch
from
e6ed329
to
d35003e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #245383
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.