nodePackages: update to latest #279469
Merged
nodePackages: update to latest #279469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synecdokey
force-pushed
the
chore/update_nodePackages
branch
from
943a0b5
to
79a5ecd
Compare
synecdokey
changed the title
Luflosi
approved these changes
Jan 8, 2024
synecdokey
force-pushed
the
chore/update_nodePackages
branch
from
79a5ecd
to
331c2b3
Compare
|
Rebased due to conflict. Quick question, what's the usual process to get something merged? |
Luflosi
approved these changes
Jan 21, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1395 |
Please extract it from nodePackages and convert it to buildNodePackage |
|
Result of 6 packages failed to build:
61 packages built:
|
Indeed. See #229475. |
|
I looked into it, and it seems like it's already been done, just not removed from the nodePackages. I'll clean that up |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Just wanted to get some updates for an lsp server I'm using, took the opportunity to get everything since it's a bit more straightforward.
Generated using
/pkgs/development/node-packages/generate.shThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.