flatpak-builder: 1.2.3 -> 1.4.2 #280152
Merged
flatpak-builder: 1.2.3 -> 1.4.2 #280152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthsmn
force-pushed
the
flatpak-builder-update
branch
8 times, most recently
from
26172be
to
b623ca4
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3265 |
pbsds
reviewed
Feb 29, 2024
Yeah, I can maintain it. |
arthsmn
force-pushed
the
flatpak-builder-update
branch
from
b623ca4
to
d1ff0ac
Compare
arthsmn
changed the title
arthsmn
force-pushed
the
flatpak-builder-update
branch
from
d1ff0ac
to
4fa5330
Compare
arthsmn
changed the title
|
The tarball provided is using an old/incomplete version of the libglnx, I'm talking with upstream about this to see what can be done. Edit: upstream provided a fixed tarball. |
2 tasks
arthsmn
force-pushed
the
flatpak-builder-update
branch
from
4fa5330
to
5f82728
Compare
|
Result of 7 packages marked as broken and skipped:
1 package blacklisted:
8 packages failed to build:
765 packages built:
All failing packages also fail on hydra except:
LGTM |
|
Could you retarget the PR to staging? Make sure to mark it as draft first in case your master is ahead of staging, so lots of people don't get pinged for review by ofborg |
arthsmn
force-pushed
the
flatpak-builder-update
branch
from
5f82728
to
c0aefce
Compare
Done. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/flatpak/flatpak-builder/releases/tag/1.4.2
Closes: #279784
I replaced the old build tool with meson, as recommended by upstream. Needed to adapt appstream to build with compose support, so flatpak-builder can use it. Also, updated the patch to fix paths and modified the test one, and also removed unused parts.
Btw should I set a withCompose in appstream and make it optional?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.