gdal: add java bindings #280279
gdal: add java bindings #280279
Conversation
|
Thank you for contribution. This PR is failing on Darwin now. |
|
Maybe we should also consider building with java as optional feature using |
|
Result of 7 packages marked as broken and skipped:
24 packages failed to build:
79 packages built:
|
@imincik Thanks for your |
Alternatively, if it's possible to put the java bindings in a separate output, we could always build the java bindings and not worry about closure bloat in environments containing gdal with+without java support, as they'd both use the same underlying C++ library. But if it's difficult to split out a |
|
The GDAL teams defaults to building it Java (if That being said, I'm not the maintainer. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/week-in-geospatial-team/37035/3 |
|
Looks like this doesn't build on darwin. From the ofBorg log: Seems like ti There are several I have no way to inspect this on a Mac. |
|
Sorry, I can't help with Darwin either. |
|
Ah, now that I think about this. I guess it worked just fine because of the log line but the test fails. I don't have experience with Mac. |
|
@imincik I managed to fix the Darwin issue. The problem was that I symlinked a |
|
Phew ... now that I found some debug leftovers, should I squash this whole PR? EDIT: Done. |
|
@imincik All checks are passing now. This PR is ready from my point of view. Do you mind having another look into this? |
There was a problem hiding this comment.
Thank you very much for your effort @rollf .
I requested some changes. My biggest concern is whether we should build GDAL with java by default or not.
Also, please remove trailing dot (.) from the commit message and don't use capital letters in change description if not needed (suggested commit message should be something like gdal: add java bindings).
@thoughtpolice , as the main author of gdalMinimal would you mind to review this PR ?
|
@rollf , please remove trailing dot ( |
|
@imincik Thank you for the review. I addressed your change requests except for
Please consider this carefully. As I mentioned above, I plan to use gdal-with-Java-bindings rather soon. |
I must say I like your arguments. Personally, I am happy to take it, but I would be happier if more people will say yes. |
|
I'm no expert on closure size considerations, but @rollf's arguments convince me. Strongly. If still in doubt, I'd opt for the |
Okay, thank you. I believe I have addressed all other change requests. From my point of view, this PR is done and could be merged. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/week-in-geospatial-team/37035/6 |
|
Result of 13 packages marked as broken and skipped:
7 packages failed to build:
75 packages built:
|
|
@rollf , thanks for contributing. |
Nixpkgs PR: NixOS/nixpkgs#280279 Building with Java support is disabled by default in Geospatial NIX.
Nixpkgs PR: NixOS/nixpkgs#280279 Building with Java support is disabled by default in Geospatial NIX.
Nixpkgs PR: NixOS/nixpkgs#280279 Building with Java support is disabled by default in Geospatial NIX.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/week-in-geospatial-team/37035/7 |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.