Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python3Packages.cvxpy build; add clarabel dependancy #280682

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2024

Description of changes

init and add missing dependency https://github.com/oxfordcontrol/Clarabel.rs for cvxpy

Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.bambi
  • python311Packages.bambi.dist
12 packages built:
  • python311Packages.blackjax
  • python311Packages.blackjax.dist
  • python311Packages.clarabel
  • python311Packages.clarabel.dist
  • python311Packages.cvxpy
  • python311Packages.cvxpy.dist
  • python311Packages.jaxopt
  • python311Packages.jaxopt.dist
  • python311Packages.qutip
  • python311Packages.qutip.dist
  • python312Packages.clarabel
  • python312Packages.clarabel.dist

qutip fails to build when sandbox = true (aborts), but succeeds when relaxed.
Result of nixpkgs-review run on x86_64-darwin 1

8 packages built:
  • python311Packages.clarabel
  • python311Packages.clarabel.dist
  • python311Packages.cvxpy
  • python311Packages.cvxpy.dist
  • python311Packages.qutip
  • python311Packages.qutip.dist
  • python312Packages.clarabel
  • python312Packages.clarabel.dist

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ghost ghost changed the title python3Packages.cvxpy add clarabel dependancy fix python3Packages.cvxpy build; add clarabel dependancy Jan 13, 2024
@ghost ghost marked this pull request as ready for review January 13, 2024 08:58
@ghost ghost mentioned this pull request Jan 13, 2024
@ofborg ofborg bot requested a review from drewrisinger January 13, 2024 11:07
@ghost ghost added the backport release-23.11 Backport PR automatically label Jan 13, 2024
@ghost ghost mentioned this pull request Jan 14, 2024
13 tasks
@ghost ghost requested a review from GaetanLepage January 14, 2024 21:01
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM !

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 280682 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.bambi
  • python311Packages.bambi.dist
12 packages built:
  • python311Packages.blackjax
  • python311Packages.blackjax.dist
  • python311Packages.clarabel
  • python311Packages.clarabel.dist
  • python311Packages.cvxpy
  • python311Packages.cvxpy.dist
  • python311Packages.jaxopt
  • python311Packages.jaxopt.dist
  • python311Packages.qutip
  • python311Packages.qutip.dist
  • python312Packages.clarabel
  • python312Packages.clarabel.dist

@ghost
Copy link
Author

ghost commented Jan 14, 2024

Result of nixpkgs-review pr 280682 run on x86_64-linux 1
2 packages failed to build:
12 packages built:

Thx. forgot to mention that failed packages, bambi, fail due to unrelated failure of xarray-einstats
https://hydra.nixos.org/build/246511842

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit bcba1b0 into NixOS:master Jan 15, 2024
24 checks passed
@ghost ghost deleted the clarabel-init branch January 15, 2024 06:01
Copy link
Contributor

Successfully created backport PR for release-23.11:

@GaetanLepage
Copy link
Contributor

Thanks @a-n-n-a-l-e-e !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants