modprobed-db: init at 2.46 #280831
Merged
modprobed-db: init at 2.46 #280831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotAShelf
force-pushed
the
modprobed-db
branch
4 times, most recently
from
c0ae9c0
to
31f44cb
Compare
AndersonTorres
suggested changes
Jan 13, 2024
NotAShelf
commented
Jan 13, 2024
NotAShelf
force-pushed
the
modprobed-db
branch
from
31f44cb
to
06978b7
Compare
eclairevoyant
requested changes
Jan 14, 2024
There was a problem hiding this comment.
If you want to set PREFIX to $out it has to be done this way
Though frankly I think the previous code made more sense, DESTDIR is where you're installing to, and PREFIX is usually set to /usr or /usr/local on other distros. Semantically it is messier to set PREFIX to $out imo
NotAShelf
force-pushed
the
modprobed-db
branch
from
06978b7
to
08c9ea8
Compare
eclairevoyant
approved these changes
Jan 14, 2024
|
Result of 1 package built:
|
AndersonTorres
approved these changes
Jan 14, 2024
bzm3r
approved these changes
Jan 15, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.