[WIP] Test nixos-rebuild --build-host #281130
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Enzime
reviewed
Jan 16, 2024
| @@ -119,7 +145,7 @@ import ./make-test-python.nix ({ pkgs, ... }: { | |||
|
|
|||
| # This test also ensures that sudo is not called without --use-remote-sudo | |||
| with subtest("Deploy to root@target"): | |||
| deployer.succeed("nixos-rebuild switch -I nixos-config=/root/configuration-1.nix --target-host root@target &>/dev/console") | |||
| deployer.succeed("nixos-rebuild switch -I nixos-config=/root/configuration-1.nix --target-host root@target --build-host builder &>/dev/console") | |||
There was a problem hiding this comment.
I think it would be a good idea to separate this out into another test
There was a problem hiding this comment.
Ideally, we would have 4 tests for all combinations of --target-host and --build-host being present and not present
|
@roberth looks like to me it's failing when copying the closure from builder to target which is because the target's host key needs to known on the builder's side I think ideally we would run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I keep getting
deployer # Host key verification failed.Currently seems to be the
targethost though, which used to work. A bit puzzling, but probably nothing too crazy, considering that I did change some of the original test setup.cc @Enzime who authored the original setup for SSH to
target. WasUserKnownHostsFile=/dev/nullreally necessary?I'd really appreciate some help with this one.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.